chore(api): clean up workspace spec, remove sandbox APIs#106
chore(api): clean up workspace spec, remove sandbox APIs#106hotdata-automation[bot] wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| hotdata/api/query_runs_api.py | ||
| hotdata/api/refresh_api.py | ||
| hotdata/api/results_api.py | ||
| hotdata/api/sandboxes_api.py |
There was a problem hiding this comment.
The sandbox entries are removed from this manifest (and from the __init__.py exports), but the underlying files were not deleted from the repo. 21 sandbox files are still tracked on this branch:
hotdata/api/sandboxes_api.pyhotdata/models/{sandbox,sandbox_response,create_sandbox_request,update_sandbox_request,delete_sandbox_response,list_sandboxes_response}.pydocs/Sandbox*.md,docs/SandboxesApi.md, etc.test/test_sandbox*.py
Result: the PR title says "remove sandbox APIs," but the sandbox code, tests, and docs all remain and are still importable directly (e.g. from hotdata.api.sandboxes_api import SandboxesApi) — they're just dropped from the package's public exports. This leaves the tree inconsistent (manifest/exports vs. actual files) and the removal incomplete.
Please regenerate so these files are actually deleted, or delete them as part of this PR. git rm the 21 orphaned sandbox files so the manifest matches the tree.
|
|
||
| # macOS | ||
| .DS_Store | ||
|
|
||
| # Claude Code (local-only state) | ||
| .claude/settings.local.json | ||
| .claude/worktrees/ |
There was a problem hiding this comment.
nit: this drops the .DS_Store and .claude/ (local-only state) ignore rules, which is unrelated to an OpenAPI spec update — it looks like the generator overwrote .gitignore from its template. Removing these makes it easy to accidentally commit local macOS/Claude state. Consider restoring these entries (or moving them to a .openapi-generator-ignore-protected section so regeneration doesn't wipe them). (not blocking)
There was a problem hiding this comment.
Review
Blocking Issues
- Sandbox removal is incomplete.
.openapi-generator/FILES,hotdata/__init__.py,hotdata/api/__init__.py, andhotdata/models/__init__.pydrop all sandbox references, but the actual files were never deleted. 21 sandbox source/test/doc files remain tracked on this branch (hotdata/api/sandboxes_api.py,hotdata/models/sandbox*.py,docs/Sandbox*.md,test/test_sandbox*.py). They are still importable directly, so the PR's stated goal ("remove sandbox APIs") is not actually achieved and the manifest is now out of sync with the tree. (.openapi-generator/FILES)
Action Required
- Regenerate so the sandbox files are deleted, or
git rmthe 21 orphaned sandbox files in this PR so the manifest, exports, and tree all agree. - Note:
hotdata/configuration.pystill documentsSandboxesApi.create_sandbox/ thesession_id(X-Session-Id) flow. If sandboxes are truly going away, those references become dangling; confirm whethersession_idis intended to stay.
A non-blocking note on the .gitignore template regression is left inline.
1 participant
Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www.hotdata.dev/pull/221